Updated setup-sysvm-tmplt script, to run cmds accessing destdir with sudo#10263
Conversation
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10263 +/- ##
==========================================
Coverage 15.16% 15.16%
- Complexity 11300 11328 +28
==========================================
Files 5408 5414 +6
Lines 473912 474811 +899
Branches 57844 57911 +67
==========================================
+ Hits 71855 72017 +162
- Misses 394025 394742 +717
- Partials 8032 8052 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12198 |
- The cmds in this script are allowed for normal (cloudstack service) user when destdir is created without sudo
sureshanaparti
force-pushed
the
setup-sysvm-tmplt-script-update
branch
from
4a16185 to
0a4e462
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12302 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-12287) |
|
[SF] Trillian Build Failed (tid-12307) |
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12564 |
|
@blueorangutan test |
|
@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-12492) |
|
@sureshanaparti is this ready for review? |
not yet @Pearl1594 , still in progress. |
sureshanaparti
changed the title
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12838 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12841 |
|
@blueorangutan package |
|
@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12890 |
rajujith
left a comment
rajujith
left a comment
There was a problem hiding this comment.
LGTM.
Tested upgrade from 4.18.2. setup-sysvm-tmplt worked fine on a management server where umask is set to 0022.
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
|
||
| tmpltfile=$destdir/$localfile | ||
| tmpltsize=$(ls -l $tmpltfile | awk -F" " '{print $5}') | ||
| tmpltsize=$(sudo ls -l $tmpltfile | awk -F" " '{print $5}') |
There was a problem hiding this comment.
as teh touch $tmplfile at line 111 is without sudo, does this need it?
There was a problem hiding this comment.
@DaanHoogland needed it here, as tmpltfile is in destdir created with sudo in line 93.
There was a problem hiding this comment.
ok, than I don't understand why sudo is not needed on line 111, but if it tests alright then alright.
There was a problem hiding this comment.
I just noticed it @DaanHoogland at L111 the variable is tmplfile and here it's tmpltfile - pointing to 2 different file paths.
|
[SF] Trillian test result (tid-12822)
|
5 participants
Description
This PR updates setup-sysvm-tmplt script, to run cmds accessing destdir with sudo. These cmds in this script are are added to sudoers file, to allow for cloudstack service user 'cloud' to access destdir.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?